Skip to content

Add tokens/spl-token-minter/poseidon #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 2, 2025
Merged

Add tokens/spl-token-minter/poseidon #213

merged 8 commits into from
Jan 2, 2025

Conversation

@SohZHong
Copy link
Contributor

@SohZHong SohZHong commented Oct 25, 2024

Minor errors with mapping from Poseidon to Rust

Manual imported required for cargo.toml

  • Required to include anchor-spl/idl-build to idl-build list

Manual import required for anchor_spl

  • Required to import dependencies as shown:
use anchor_spl::{
     token::{transfer as transfer_spl, Transfer as TransferSPL, mint_to, Mint, MintTo, Token, TokenAccount},
     associated_token::AssociatedToken,
};

Missing mutable inside account

  • Required to add "mut" inside #[account()] --> #[account(mut)] for:
    to_account & mint_account under generated MintContext

@heyAyushh heyAyushh added the contribute:poseidon Adds a poseidon example contribution to the repository. label Nov 15, 2024
heyAyushh
heyAyushh reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@SohZHong
Copy link
Contributor Author

SohZHong commented Nov 26, 2024

Thank you for your time on reviewing my code! I would like to notify you that I've completed the aforementioned steps and wish to proceed with another review. Thanks!

@heyAyushh heyAyushh merged commit 2eb0bed into solana-developers:main Jan 2, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyAyushh heyAyushh heyAyushh approved these changes

Assignees

No one assigned

Labels

contribute:poseidon Adds a poseidon example contribution to the repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SohZHong @heyAyushh